Skip to content

Conversation

@joyeecheung
Copy link
Member

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/devcontainer

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it by:

  1. visiting https://github.com/joyeecheung/node/tree/update-devcontainer
  2. pressed . on my keyboard to open the web IDE,
  3. from the command palette (Cmd+Shift+P) I typed Toggle Terminal,
  4. then I pressed Continue Working in GitHub Codespaces.
  5. From there, I confirmed that running make build-ci -j4 was able to reuse the cached build artefacts (i.e. it only recompiles the diff of what landed on the local clone since the last docker image was built).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants